classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [cp-patches] RFC: WeakHashMap improvement


From: Jeroen Frijters
Subject: RE: [cp-patches] RFC: WeakHashMap improvement
Date: Wed, 26 Oct 2005 15:18:02 +0200

Roman Kennke wrote:
> Friedjof Siebert did some improvements on 
> java.util.WeakHashMap that I'd
> like to check in. They are meant to improve reliability of 
> this class by enabling the prove of a cast and the absence of
> a null-pointer.

I don't understand the point of the instanceof. If somehow there is a
bug in the code that introduces a non-WeakBucket, surely the best thing
would be to throw a ClassCastException, not silently ignore it.

reliability != hiding errors

Regards,
Jeroen




reply via email to

[Prev in Thread] Current Thread [Next in Thread]