classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: BasicMenuItemUI fix


From: Roman Kennke
Subject: Re: [cp-patches] Patch: BasicMenuItemUI fix
Date: Fri, 21 Oct 2005 17:31:26 +0200

Hi Lillian,

It looks a little strange to handle CheckBoxMenuItem specific cases in
the superclass. However, I understand that the API of
BasicCheckBoxMenuItem does not leave much room for specific handling of
this.

What looks a bit strange to me is that the specs define a method
processMouseEvent in BasicCheckBoxMenuItemUI and
BasicRadioButtonMenuItemUI but _not_ in one of the superclasses. Could
these method possibly have something to do with your problem? Can you
make any sense of these methods? Who is supposed to call these? The
MouseListener of the superclass? A private inner mouse listener? If it
was a private mouse listener, where should it be set up? These classes
don't override installListeners or something like that..

Very strange indeed.

/Roman

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil


reply via email to

[Prev in Thread] Current Thread [Next in Thread]