Re: [cp-patches] javax.swing.text.html.parser cleanup

[Meskauskas Audrius]

Great patch and great work! The only arguable place is the ContentModel 
parameterless constructor. It is needed just because there are other 
constructors that take parameters.  Fields are initialised to default 
values (null and 0) without additional code. Nothing to do between { }. 
Please remove that FIXME.

Regards

Audrius.


>Index: javax/swing/text/html/parser/ContentModel.java

===================================================================
RCS file: 
/cvsroot/classpath/classpath/javax/swing/text/html/parser/ContentModel.java,v
retrieving revision 1.3
diff -u -r1.3 ContentModel.java
--- javax/swing/text/html/parser/ContentModel.java      2 Jul 2005 20:32:51 
-0000       1.3
+++ javax/swing/text/html/parser/ContentModel.java      19 Oct 2005 14:31:58 
-0000
@@ -98,6 +98,7 @@
  /** Create a content model initializing all fields to default values. */
  public ContentModel()
  {
+    // FIXME: Implement this.
  }