Re: [cp-patches] FYI: filled empty blocks in javax.swing.colorchooser

[Roman Kennke]

Am Dienstag, den 18.10.2005, 22:58 +0200 schrieb Robert Schuster:
> Hi Roman,
> 
> > Index: javax/swing/colorchooser/DefaultSwatchChooserPanel.java
> > ===================================================================
> > RCS file: 
> > /cvsroot/classpath/classpath/javax/swing/colorchooser/DefaultSwatchChooserPanel.java,v
> > retrieving revision 1.5
> > diff -u -r1.5 DefaultSwatchChooserPanel.java
> > --- javax/swing/colorchooser/DefaultSwatchChooserPanel.java 2 Jul 2005 
> > 20:32:49 -0000       1.5
> > +++ javax/swing/colorchooser/DefaultSwatchChooserPanel.java 18 Oct 2005 
> > 20:28:28 -0000
> > @@ -587,6 +587,7 @@
> >       */
> >      public void addLayoutComponent(String name, Component comp)
> >      {
> > +      // Nothing to do here.
> >      }
> >  
> >      /**
> > @@ -634,6 +635,7 @@
> >       */
> >      public void removeLayoutComponent(Component comp)
> >      {
> > +      // Nothing to do here.
> >      }
> >  
> >      /**
> > @@ -786,6 +788,7 @@
> >     */
> >    public void updateChooser()
> >    {
> > +    // Nothing to do here yet.
> >    }
> >  
> I dont understand this. Does this mean
> 
> // TODO: implement this
> 
> or not?

No, it doesn't. In this particular case, this method has to be
overridden, since it is declared abstract in the superclass, but there
is no use of it in this place. At least, I cannot see any. This is why I
put in // Nothing to do here. and not a // TODO.

/Roman

signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil