classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: textfield fixes


From: Anthony Balkissoon
Subject: Re: [cp-patches] FYI: textfield fixes
Date: Thu, 13 Oct 2005 15:06:42 -0400

As discussed on IRC, the repaint call should be there.  In the future we
may want to optimize by calculating the exact area that should be
repainted and calling damageLinesInRange appropriately but for now that
mechanism is not in place so this call is needed and appropriate.

--Tony

On Thu, 2005-10-13 at 20:29 +0200, Roman Kennke wrote:
> Am Donnerstag, den 13.10.2005, 11:57 -0400 schrieb Anthony Balkissoon:
> > The first part of this patch was wrong, removing the repaint from
> > updateDamage.  The host container should be repainted if a new line was
> > added.  There is a test case at the bottom of this message demonstrating
> > that.  I reverted that part of the patch.
> 
> Nope, the patch is not wrong. The repaint is issued in
> damageLinesInRange, if something's not working correctly, then there's
> something wrong in this method. I'll fix your testcase.
> 
> /Roman
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]