|
From: | Robert Schuster |
Subject: | Re: [cp-patches] FYI: javax.swing.filechooser.FileSystemView |
Date: | Tue, 11 Oct 2005 13:45:43 +0200 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; de-AT; rv:1.7.12) Gecko/20051005 |
Hi David, yesterday we had a discusssion about stub methods and to-be-continued methods. I think the one you tackled with looks like one. > + if (defaultFileSystemView == null) > + { > + if (File.separator.equals("/")) > + defaultFileSystemView = new UnixFileSystemView(); > + // else if (File.Separator.equals("\")) > + // return new Win32FileSystemView(); > + // else > + // return new GenericFileSystemView(); > + } > + return defaultFileSystemView; > } Am I right that the comments should suggest to implement a Win32FileFileSystemView and a GenericFileSystemView() at some time? If so it would be nice to have a FIXME telling that and a corresponding bug report. cu Robert
[Prev in Thread] | Current Thread | [Next in Thread] |