Re: [cp-patches]: FYI: JTree fix

[Lillian Angel]

A few NPEs were being raised after the most recent changes.

2005-10-06  Lillian Angel  <address@hidden>

        * javax/swing/plaf/basic/BasicTreeUI.java
        (startEditing): Should always change the bounds, whenever
        we start editing.
        (paintRow): Fixed location where editing component should
        be drawn. The constant takes care of the space around the
        icon.
        * javax/swing/JTree.java
        (JTree): Called updateUI first so currentVisiblePath is
        cached right away. Prevents NPEs.


On Thu, 2005-10-06 at 09:45 -0400, Lillian Angel wrote:
> The click-area for a leaf was slightly off. Fixed.
> 
> 2005-10-06  Lillian Angel  <address@hidden>
> 
>         * javax/swing/plaf/basic/BasicTreeUI.java
>         (mousePressed): Shouldn't change x location for leaf.
> 
> 
> 
> On Wed, 2005-10-05 at 17:49 -0400, Lillian Angel wrote:
> > Small fix. Added in a comment as a reminder to fix last bit of painting
> > problem.
> > 
> > 2005-10-05  Lillian Angel  <address@hidden>
> > 
> >         * javax/swing/plaf/basic/BasicTreeUI.java
> >         (paintRow): Fixed indentation.
> >         (updateCurrentVisiblePath): Added FIXME
> >         comment.
> > 
> > 
> > 
> > On Wed, 2005-10-05 at 17:28 -0400, Lillian Angel wrote:
> > > Fixed up BasicTreeUI because it was not efficent when painting.
> > > 
> > > 2005-10-05  Lillian Angel  <address@hidden>
> > > 
> > >         * javax/swing/plaf/metal/MetalTreeUI.java
> > >         (installUI): Fixed to call toggleExpandState instead.
> > >         * javax/swing/plaf/basic/BasicTreeUI.java
> > >         (getPathForRow): Used currentVisiblePath to get Path.
> > >         (getRowForPath): Used currentVisiblePath to get row.
> > >         (getRowCount): Returned currentVisiblePath length.
> > >         (updateLayoutCacheExpandedNodes): Took out unneeded code.
> > >         (installUI): Fixed to call toggleExpandState instead.
> > >         (getPreferredSize): Made more efficent by using 
> > >   currentVisiblePath.
> > >         (toggleExpandState): Called updateCurrentVisiblePath.
> > >         (getCellLocation): Made more efficent.
> > >         (paintNode): Removed.
> > >         (paintRecursive): Made more efficent, changed paintNode calls to
> > >         paintRow.
> > >         (getNextVisibleNode): Reimplemented to use currentVisiblePath.
> > >         (getPreviousVisibleNode): Likewise.
> > >         (paintRow): Implemented.
> > >         (updateCurrentVisiblePath): New helper used to cache the current
> > >         visible path.
> > > 
> > > _______________________________________________
> > > Classpath-patches mailing list
> > > address@hidden
> > > http://lists.gnu.org/mailman/listinfo/classpath-patches
> > _______________________________________________
> > Classpath-patches mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/classpath-patches
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

patch.diff
Description: Text Data