Re: [cp-patches] RFC: VMClassLoader : hashmap for jars from property java.boot.class.path

[Nicolas Geoffray]

Hi David,

David Lichteblau wrote:

> Hi,
>
> Quoting Nicolas Geoffray (address@hidden):
> [...]
>  
>
> > 2005-10-06  Nicolas Geoffray  <address@hidden>
> >
> >         * vm/reference/java/lang/VMClassLoader.java
> >       (getResources): uses a new static field HashMap to
> >       store opened zip files from property java.boot.class.path.
> >    
>
> your patch contains a bugfix that you did not mention but that would be
> nice to see applied (independently of other changes): Without the
> f.exists() check the reference implementation does not work properly.
>
>  
Yes, I forgot to mention it. When i'll get a cvs write access and be 
notified that the patch is ok, I will commit the changes separately.
Thanks for the reminder.

> (Presumably all VM authors know this already and override it.)
>
>  
>
> > --- classpath-0.18/vm/reference/java/lang/VMClassLoader.java    2005-10-06 
> > 10:26:34.000000000 +0200
> > +++ classpath-0.18-jnjvm/vm/reference/java/lang/VMClassLoader.java      
> > 2005-10-06 14:47:02.000000000 +0200
> > @@ -139,8 +142,9 @@
> >           {
> >             try
> >               {
> > -               v.add(new URL("file://"
> > -                 + new File(file, name).getAbsolutePath()));
> > +                File f = new File(file, name);
> > +                if(!f.exists()) continue;
> > +                v.add(new URL("file://" + f.getAbsolutePath()));
> >    
>
>
> d.
>
>
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches
>