Re: [cp-patches] Patch: dssi control handling

[Mark Wielaard]

Hi Anthony,

On Tue, 2005-10-04 at 08:21 -0700, Anthony Green wrote:
> The following patch sets up the controller mapping and processes MIDI
> controller events.
> 
> OK?

You obviously are the person that knows this code best. You didn't say
what kind of feedback you would like so I am giving the feedback I am
best at "maintainer nitpicks"...

> +/* The original get_port_default() and set_control() routines were
> + * copied from the DSSI source distribution and are covered by the
> + * following copyright and license...
> + *
> + * Copyright 2004 Chris Cannam, Steve Harris and Sean Bolton.
> + * 
> + * Permission to use, copy, modify, distribute, and sell this software
> + * for any purpose is hereby granted without fee, provided that the
> + * above copyright notice and this permission notice are included in
> + * all copies or substantial portions of the software.
> + */

In general this is free software and gpl-compatible, so we can use that.
But we should list all such things explicitly in the file LICENSING with
an explicit reference to the upstream source. I will also send an email
to FSF legal to alert them about our inclusion of this for their records
and input.

And if at all possible it would be good to have these two routines in a
separate file so it is clear we are not the original authors/upstream
for this code. There (or in a separate README) you can also list what
changes (if any) we made to this code.

See for examples the LICENSE file and the external project READMEs in
the external sub-directories.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part