[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [cp-patches] Patch: start of ALSA MIDI provider code
From: |
Mark Wielaard |
Subject: |
Re: [cp-patches] Patch: start of ALSA MIDI provider code |
Date: |
Mon, 03 Oct 2005 02:52:26 +0200 |
On Sun, 2005-10-02 at 17:10 -0700, Anthony Green wrote:
> This patch takes care of many of your comments, but not all.
So the --disable and gcj compilation are fixed.
> It also adds a DSSI[1] provider. With this I was able to, in a few
> lines of Java code, connect my external MIDI keyboard to a DSSI
> soft-synth wired to jack[2] audio output and play music. There's still
> lots to do, but this is a nice milestone.
And some cool new stuff was added :) Nice!
> If this patch isn't acceptable for the cvs trunk, would it be OK if I
> checked this into a new cvs branch? I feel uncomfortable keeping all
> this local.
Now that the show stoppers are fixed you can check it in. That is useful
because then others can play with it. But I do expect you to clean up
the other things I mentioned. CVS shouldn't be something you dump
half-finished stuff in without a clear plan how to get it finished.
Thanks,
Mark
But I still don't like the non-Javadoc stuff it doesn't add anything
useful.
signature.asc
Description: This is a digitally signed message part