classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] RFC: PR classpath/24086, PR classpath/24091 (HTTPURLCon


From: Tom Tromey
Subject: Re: [cp-patches] RFC: PR classpath/24086, PR classpath/24091 (HTTPURLConnection et al.)
Date: 01 Oct 2005 12:02:30 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

>>>>> "David" == David Daney <address@hidden> writes:

David> This patch is a partial rewrite of the
David> gnu/java/net/protocol/http package.

Awesome!

I gave this a quick read-through.  I want to read it again, and I'd
like it if Chris commented on it.

David>      Map ret = new LinkedHashMap();

Might as well declare locals with the most specific type.
Not a big deal, but in this case avoids some needless invokeinterface
calls.

David> -    ret.put("", Collections.singletonList(getStatusLine(response)));
David> +    ret.put(null, Collections.singletonList(getStatusLine(response)));

This, btw, is PR 24104.

Tom




reply via email to

[Prev in Thread] Current Thread [Next in Thread]