[cp-patches] Re: [commit-cp] classpath ./ChangeLog javax/swing/plaf/basic/Ba...

[David Gilbert]

Hi Roman,

I didn't look at it closely yet, but running the ButtonDemo I noticed 
all the radio buttons and check boxes are drawing the focus regardless 
of whether the component has the focus, and I wondered if it might be 
due to the patch below.

Regards,

Dave

Roman Kennke wrote:

> CVSROOT:        /cvsroot/classpath
> Module name:    classpath
> Branch:         
> Changes by:     Roman Kennke <address@hidden>     05/09/28 15:17:42
>
> Modified files:
> 	.              : ChangeLog 
> 	javax/swing/plaf/basic: BasicButtonUI.java 
> 	                        BasicRadioButtonUI.java 
> 	                        BasicToggleButtonUI.java 
>
> Log message:
>         2005-09-28  Roman Kennke  <address@hidden>
>         
>         * javax/swing/plaf/basic/BasicButtonUI.java
>         (currentIcon): Made method package private, so that other button
>         UIs can access it.
>         (paint): Removed unnecessary call to paintButtonNormal().
>         (paintButtonNormal): Removed unnecessary method. The background
>         is already filled correctly when paint() is entered.
>         * javax/swing/plaf/basic/BasicRadioButtonUI.java
>         (paint): Call the new paintFocus() method instead of the inherited
>         from BasicButtonUI.
>         (paintFocus): New method. Paints the focus indicator for
>         JRadioButtons and subclasses.
>         * javax/swing/plaf/basic/BasicToggleButtonUI.java
>         (paint): New method. Implements custom painting. Mostly, this
>         is needed in order to call the new paintIcon() method.
>         (paintIcon): New method. Narrows the types from the super-class
>         method.
>
> CVSWeb URLs:
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/ChangeLog.diff?tr1=1.5016&tr2=1.5017&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/javax/swing/plaf/basic/BasicButtonUI.java.diff?tr1=1.27&tr2=1.28&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/javax/swing/plaf/basic/BasicRadioButtonUI.java.diff?tr1=1.10&tr2=1.11&r1=text&r2=text
> http://savannah.gnu.org/cgi-bin/viewcvs/classpath/classpath/javax/swing/plaf/basic/BasicToggleButtonUI.java.diff?tr1=1.11&tr2=1.12&r1=text&r2=text
>
>
>
>
>
>