Re: [cp-patches] RFC: 2 swing.text.Utilities methods implemented

[Anthony Balkissoon]

A fix to these two methods.  Oddly structured Documents were causing
GapContent errors (on the JDK as well, this isn't representative of our
implementation being fragile), so I replaced get Element-specific
getText call with a general getText().  This fixes the problem.

2005-09-27  Anthony Balkissoon  <address@hidden>

        * javax/swing/text/Utilities.java:
        (getRowEnd): Call getText() rather than trying to get the Element-
        specific portion to avoid GapContent errors.
        (getRowStart): Likewise.

--Tony

On Tue, 2005-09-27 at 12:47 -0400, Anthony Balkissoon wrote:
> On Roman's advice, I changed the 2 methods to use binary searching
> rather than sequential searching.  This is now committed.
> 
> 2005-09-27  Anthony Balkissoon  <address@hidden>
> 
>       * javax/swing/text/Utilities.java:
>       (getRowEnd): New method.
>       (getRowStart): New method.
> 
> --Tony
> 
> On Mon, 2005-09-26 at 16:34 -0400, Anthony Balkissoon wrote:
> > I implemented getRowStart and getRowEnd in javax.swing.text.Utilities.
> > This is RFC because of the issue raised in the large comment in each of
> > this methods (namely, performance).  Some comments would be appreciated.
> > 
> > 
> > 2005-09-26  Anthony Balkissoon  <address@hidden>
> > 
> >     * javax/swing/text/Utilities.java:
> >     (getRowEnd): New method.
> >     (getRowStart): New method.
> > 
> > --Tony
> > _______________________________________________
> > Classpath-patches mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/classpath-patches
> _______________________________________________
> Classpath-patches mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/classpath-patches

UtilitiesGetRowStartEndFix.diff
Description: Text Data