classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches]: GtkDialogPeer fix and Tree fix


From: Lillian Angel
Subject: Re: [cp-patches]: GtkDialogPeer fix and Tree fix
Date: Mon, 26 Sep 2005 13:56:03 -0400

On Mon, 2005-09-26 at 13:23 -0400, Thomas Fitzsimmons wrote:
> Hi,
> 
> You should include in each patch message you send to this list a
> description of what the patch does.  This one in particular deserves a
> description since we're using reflection tricks (which are warranted in
> this case, in my opinion).
> 
> Tom

No problem.
In this patch, I used reflection to get an instance of the private class
JPopupMenu.HeavyWeightPopup. If the dialog is an instance of this class,
the hint is set to GDK_WINDOW_TYPE_HINT_MENU. Also, if the dialog is an
instance of JToolTip the hint is also changed.

I created this patch since PopupMenus should not remove the focus from
the parent window. Also, ToolTips should never remove the focus from the
parent window. This was happening with HeavyWeightPopups and ToolTips on
HeavyWeightPopups.

> On Mon, 2005-09-26 at 11:20 -0400, Lillian Angel wrote:
> > 2005-09-26  Lillian Angel  <address@hidden>
> > 
> >         * gnu/java/awt/peer/gtk/GtkDialogPeer.java
> >         (create): If the dialog is a toolTip or a
> >         PopupMenu, its type should be set to:
> >         GDK_WINDOW_TYPE_HINT_MENU, so the parent
> >         window does not lose focus.
> >         * javax/swing/JTree.java
> >         (setModel): Should update the UI everytime the
> >         model is changed.
> >         * javax/swing/plaf/basic/BasicTreeUI.java
> >         (installUI): Should not set the root to be visible.
> >         (paintControlIcons): changed to use getVisibleRect.
> >         * javax/swing/plaf/metal/MetalTreeUI.java
> >         (installUI): Should not set the root to be visible.
> > 
> > _______________________________________________
> > Classpath-patches mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/classpath-patches
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]