Re: [Fwd: Re: [cp-patches] Patch: add missing switch break?]

[Chris Burdess]

Mark Wielaard wrote:
> > From reading this code, I don't think we really want to fall-through
> > on this switch case.   OK?
> >
> > 2005-09-13  Anthony Green  <address@hidden>
> >
> >         * gnu/xml/aelfred2/XmlParser.java: Add missing break;.
>
> This looks OK to me. Chris can you have a look?
>
> Anthony, don't forget to update the copyright year in the header.
>
> Thanks,
>
> Mark
>
> > Index: gnu/xml/aelfred2/XmlParser.java
> > ===================================================================
> > RCS
> > file: /cvsroot/classpath/classpath/gnu/xml/aelfred2/XmlParser.java,v
> > retrieving revision 1.7
> > diff -u -p -r1.7 XmlParser.java
> > --- gnu/xml/aelfred2/XmlParser.java     2 Jul 2005 20:32:15
> > -0000       1.7
> > +++ gnu/xml/aelfred2/XmlParser.java     14 Sep 2005 06:45:48 -0000
> > @@ -2185,6 +2185,7 @@ loop:
> >                    {
> >                      nest++;
> >                    }
> > +               break;
> >                case ']':
> >                  if (tryRead("]>"))
> >                    {

I think the patch looks reasonable.
--
Chris Burdess