classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] FYI: MetalLookAndFeel


From: Roman Kennke
Subject: Re: [cp-patches] FYI: MetalLookAndFeel
Date: Tue, 20 Sep 2005 14:53:02 +0200 (CEST)
User-agent: SquirrelMail/1.4.4

Hi,

> Am Dienstag, den 20.09.2005, 12:02 +0000 schrieb David Gilbert:
>> Roman Kennke wrote:
>>
>> >I added some defaults to the MetalLookAndFeel (text field borders).
>> >
>> >-      "TextField.border", MetalBorders.getTextFieldBorder(),
>> >+      "TextField.border",
>> >+      new BorderUIResource(MetalBorders.getTextFieldBorder()),
>> >
>> >
>> >
>> Hi Roman,
>>
>> When I saw this I wondered if the getTextFieldBorder() method should
>> return a border that already implements UIResource.  I added some Mauve
>> tests that confirm that it does, so I think this change should be
>> reverted and getTextFieldBorder() fixed instead.
>
> Yeah ok, I'll do this and check it in. What about the getTextBorder()
> method? I assume it'll be the same here.

Ok, I have fixed this.

2005-09-20  Roman Kennke  <address@hidden>

        * javax/swing/plaf/metal/MetalBorders.java
        (getTextFieldBorder): This method must return an BorderUIResource
        instance. Fixed.

/Roman

Attachment: MetalBorders.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]