classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] fix hang in GtkComponentPeer.isRealized


From: Thomas Fitzsimmons
Subject: [cp-patches] fix hang in GtkComponentPeer.isRealized
Date: Tue, 20 Sep 2005 00:35:48 -0400

Hi,

I committed this patch from David Lichteblau to fix a potential hang in
GtkComponentPeer.isRealized.

Tom

2005-09-20  Thomas Fitzsimmons  <address@hidden>

        PR awt/23951
        * native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
        (isRealized): Leave GDK critical region when exiting early.

Index: native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c
===================================================================
RCS file: 
/cvsroot/classpath/classpath/native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c,v
retrieving revision 1.53
diff -u -r1.53 gnu_java_awt_peer_gtk_GtkComponentPeer.c
--- native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c        12 Sep 
2005 03:46:42 -0000      1.53
+++ native/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkComponentPeer.c        20 Sep 
2005 04:11:43 -0000
@@ -762,7 +762,10 @@
   ptr = NSA_GET_PTR (env, obj);
 
   if (ptr == NULL)
-    return FALSE;
+    {
+      gdk_threads_leave ();
+      return FALSE;
+    }
 
   ret_val = GTK_WIDGET_REALIZED (GTK_WIDGET (ptr));
 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]