[cp-patches] FYI: BasicComboBoxRenderer

[David Gilbert]

I committed this patch to remove the focus border from JComboBoxes under the 
BasicLookAndFeel - this matches the reference implementation more closely:

2005-09-18  David Gilbert  <address@hidden>

        * javax/swing/plaf/basic/BasicComboBoxRenderer.java
        (BasicComboBoxRenderer): set no focus border,
        (getListCellRendererComponent): set background color if cell has focus,
        removed border switching code.

Regards,

Dave

Index: javax/swing/plaf/basic/BasicComboBoxRenderer.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/javax/swing/plaf/basic/BasicComboBoxRenderer.java,v
retrieving revision 1.6
diff -u -r1.6 BasicComboBoxRenderer.java
--- javax/swing/plaf/basic/BasicComboBoxRenderer.java   16 Sep 2005 10:52:05 
-0000      1.6
+++ javax/swing/plaf/basic/BasicComboBoxRenderer.java   18 Sep 2005 15:46:24 
-0000
@@ -49,8 +49,6 @@
 import javax.swing.ListCellRenderer;
 import javax.swing.SwingConstants;
 import javax.swing.SwingUtilities;
-import javax.swing.UIDefaults;
-import javax.swing.UIManager;
 import javax.swing.border.Border;
 import javax.swing.border.EmptyBorder;
 
@@ -74,6 +72,7 @@
   public BasicComboBoxRenderer()
   {
     setHorizontalAlignment(SwingConstants.LEFT);
+    setBorder(noFocusBorder);
   }
 
   /**
@@ -129,7 +128,7 @@
     
     setOpaque(true);
 
-    if (isSelected)
+    if (isSelected || cellHasFocus)
       {
         setBackground(list.getSelectionBackground());
         setForeground(list.getSelectionForeground());
@@ -142,14 +141,6 @@
 
     setEnabled(list.isEnabled());
     setFont(list.getFont());
-
-    // Use focusCellHighlightBorder when renderer has focus and 
-    // noFocusBorder otherwise
-    if (cellHasFocus)
-      setBorder(UIManager.getBorder("List.focusCellHighlightBorder"));
-    else
-      setBorder(noFocusBorder);
-
     return this;
   }