classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Patch: FYI: minor cleanups


From: Tom Tromey
Subject: [cp-patches] Patch: FYI: minor cleanups
Date: 17 Sep 2005 09:39:43 -0600
User-agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50

I'm checking this in.

This fixes some minor problems pointed out by eclipse.  In
particular, a couple more javadoc fixes, and the addition of a
serialVersionUID.

I've been doing some minor cleanups by telling eclipse to filter
warnings to just java.{io,lang,util} (excluding some weirder things
like regex) and then fixing whatever is there.  There are still a few
buglets in this area, but not much; there are a few missing
serialVersionUIDs where Sun doesn't provide the value in their javadoc
:-(

Tom

Index: ChangeLog
from  Tom Tromey  <address@hidden>

        * java/util/prefs/Preferences.java (systemNodeForPackage):
        Javadoc fix.
        (userNodeForPackage): Likewise.
        * java/util/logging/LoggingPermission.java (serialVersionUID):
        New field.
        * java/io/ObjectInputStream.java (parseContent): Javadoc fix.

Index: java/io/ObjectInputStream.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/io/ObjectInputStream.java,v
retrieving revision 1.67
diff -u -r1.67 ObjectInputStream.java
--- java/io/ObjectInputStream.java      14 Sep 2005 14:47:47 -0000      1.67
+++ java/io/ObjectInputStream.java      17 Sep 2005 15:37:55 -0000
@@ -167,7 +167,7 @@
     * Handles a content block within the stream, which begins with a marker
     * byte indicating its type.
     *
-    * @param byte the byte marker.
+    * @param marker the byte marker.
     * @return an object which represents the parsed content.
     * @throws ClassNotFoundException if the class of an object being
     *                                read in cannot be found.
Index: java/util/logging/LoggingPermission.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/java/util/logging/LoggingPermission.java,v
retrieving revision 1.3
diff -u -r1.3 LoggingPermission.java
--- java/util/logging/LoggingPermission.java    2 Jul 2005 20:32:44 -0000       
1.3
+++ java/util/logging/LoggingPermission.java    17 Sep 2005 15:37:56 -0000
@@ -41,6 +41,8 @@
 public final class LoggingPermission
   extends java.security.BasicPermission
 {
+  private static final long serialVersionUID = 63564341580231582L;
+
   /**
    * Creates a new LoggingPermission.
    *
Index: java/util/prefs/Preferences.java
===================================================================
RCS file: /cvsroot/classpath/classpath/java/util/prefs/Preferences.java,v
retrieving revision 1.11
diff -u -r1.11 Preferences.java
--- java/util/prefs/Preferences.java    2 Jul 2005 20:32:44 -0000       1.11
+++ java/util/prefs/Preferences.java    17 Sep 2005 15:37:56 -0000
@@ -230,15 +230,15 @@
     }
 
     /**
-     * Returns the system preferences node for the package of an object.
-     * The package node name of the object is determined by dropping the
-     * class name of the object of the fully quallified class name and
-     * replacing all '.' to '/' in the package name. If the class of the
+     * Returns the system preferences node for the package of a class.
+     * The package node name of the class is determined by dropping the
+     * final component of the fully qualified class name and
+     * changing all '.' to '/' in the package name. If the class of the
      * object has no package then the package node name is "&lt;unnamed&gt;".
-     * The returened node is <code>systemRoot().node(packageNodeName)</code>.
+     * The returned node is <code>systemRoot().node(packageNodeName)</code>.
      *
-     * @param o Object whose default system preference node is requested
-     * @returns system preferences node that should be used by object o
+     * @param c Object whose default system preference node is requested
+     * @returns system preferences node that should be used by class c
      * @exception SecurityException when a security manager is installed and
      * the caller does not have <code>RuntimePermission("preferences")</code>.
      */
@@ -249,15 +249,15 @@
     }
 
     /**
-     * Returns the user preferences node for the package of an object.
-     * The package node name of the object is determined by dropping the
-     * class name of the object of the fully quallified class name and
-     * replacing all '.' to '/' in the package name. If the class of the
+     * Returns the user preferences node for the package of a class.
+     * The package node name of the class is determined by dropping the
+     * final component of the fully qualified class name and
+     * changing all '.' to '/' in the package name. If the class of the
      * object has no package then the package node name is "&lt;unnamed&gt;".
-     * The returened node is <code>userRoot().node(packageNodeName)</code>.
+     * The returned node is <code>userRoot().node(packageNodeName)</code>.
      *
-     * @param o Object whose default user preference node is requested
-     * @returns user preferences node that should be used by object o
+     * @param c Object whose default userpreference node is requested
+     * @returns userpreferences node that should be used by class c
      * @exception SecurityException when a security manager is installed and
      * the caller does not have <code>RuntimePermission("preferences")</code>.
      */




reply via email to

[Prev in Thread] Current Thread [Next in Thread]