classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [cp-patches] Patch: FYI: PR classpath/22689


From: Mark Wielaard
Subject: Re: [cp-patches] Patch: FYI: PR classpath/22689
Date: Fri, 16 Sep 2005 22:02:54 +0200

Hi,

On Fri, 2005-09-16 at 13:15 -0600, Tom Tromey wrote:
> from  Tom Tromey  <address@hidden>
>       PR classpath/22689:
>       * java/io/PrintWriter.java (closed): New field.
>       (checkError): Only flush if stream not closed.
>       (close): Set 'closed'.
>
> [ ... in close() ... ]
>      try
>        {
> -     out.close();
> +        out.close();
> +        closed = true;
>        }
>      catch (IOException ex)
>        {

Shouldn't this be conditional on closed? And shouldn't closed be set to
true even if out.close() throws an IOException?

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]