Re: [cp-patches] Patch: improve error handling in String

[Tom Tromey]

>>>>> "David" == David Daney <address@hidden> writes:

David> Anthony Green wrote:
>> -      // XXX - Ignore coding exceptions? They shouldn't really happen.
>> -      return null;
>> +      // This shouldn't really happen.
>> +      throw new Error(e);

David> Whould it be better to use InternalError?  That is a little
David> more specific.

Yeah, I thought we had a rule about this, but I can't find it now.  I
think InternalError makes sense here (and furthermore should be in
hacking.texinfo).  Comments?

Tom