Re: [cp-patches] FYI: GlyphView additions

[Mark Wielaard]

Hi Roman,

On Wed, 2005-09-14 at 01:19 +0200, Roman Kennke wrote:
> This (together with the next view commits) basically enabled this:
> http://kennke.org/~roman/styletext.png

That looks cool!
Feel free to add something like that to GNU Classpath Examples :)

>         (getBreakWeight): New method.
>         (changedUpdate): New method.
>         (insertUpdate): New method.
>         (removeUpdate): New method.
>         (createFragment): New method.
> [...]
> +  public int getBreakWeight(int axis, float pos, float len)
> +  {
> +    // FIXME: Implement me.
> +    throw new AssertionError("Not yet implemented.");
> +  }
> +
> +  public void changedUpdate(DocumentEvent e, Shape a, ViewFactory vf)
> +  {
> +    // FIXME: Implement me.
> +    throw new AssertionError("Not yet implemented.");
> +  }
> +
> +  public void insertUpdate(DocumentEvent e, Shape a, ViewFactory vf)
> +  {
> +    // FIXME: Implement me.
> +    throw new AssertionError("Not yet implemented.");
> +  }
> +
> +  public void removeUpdate(DocumentEvent e, Shape a, ViewFactory vf)
> +  {
> +    // FIXME: Implement me.
> +    throw new AssertionError("Not yet implemented.");
> +  }
> +
> +  public View createFragment(int p0, int p1)
> +  {
> +    // FIXME: Implement me.
> +    throw new AssertionError("Not yet implemented.");
> +  }

I think you should not add these methods unless there is a very
important reason to. This way people might compile their code against
GNU Classpath only to find out during runtime that it doesn't work...

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part