classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] Patch: Scrolling capabilities


From: Anthony Balkissoon
Subject: [cp-patches] Patch: Scrolling capabilities
Date: Mon, 12 Sep 2005 17:05:21 -0400

Many of the bugs to which I'm assigned involve scrolling, so I've
implemented some necessary methods, mostly in
javax.swing.ScrollPaneLayout.  Already scrolling in some places has
improved but I'll be checking in bug-specific patches over the next few
days.

In ScrollPaneLayout I threw IllegalArgumentExceptions in places where
the JDK was doing so, and this crashed some Swing apps I had here.  That
explains the changes to JScrollPane.

The JViewport changes are common to bugs where the window needed to be
resized before scrollbars appeared.  The non-common parts of these bugs
will be investigated over the next few days.

Patch attached.

2005-09-12  Anthony Balkissoon  <address@hidden>

        * javax/swing/JScrollPane.java:
        (addNonNull): Changed from adding to container with no constraints to
        adding to container with the appropriate ScrollPaneConstant as a 
        constraint.  This avoids IllegalArgumentExceptions in ScrollPaneLayout.
        (setColumnHeader): Added constraint to addNonNull call.
        (setCorner): Likewise.
        (setHorizontalScrollBar): Likewise.
        (setRowHeader): Likewise.
        (setVerticalScrollBar): Likewise.
        (setViewport): Likewise.
        * javax/swing/JViewport.java:
        (setViewSize): Don't set the size or fireStateChanged unless the new 
        size is different from the old size.
        (setView): Reset isViewSizeSet to false.
        * javax/swing/ScrollPaneLayout:
        (addSingletonComponent): Implemented and documented.
        (addLayoutComponent): Throw an IllegalArgumentException if key is 
        not one of the appropriate ScrollPaneConstants constants.  Added docs.
        (setVerticalScrollBarPolicy): Likewise.
        (setHorizontalScrollBarPolicy): Likewise.
        (getCorner): Added docs.

--Tony

Attachment: ScrollingCapabilities.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]