[cp-patches] Re: fix more JComboBox crashes

[Thomas Fitzsimmons]

On Fri, 2005-09-09 at 11:38 -0400, Thomas Fitzsimmons wrote:
> Hi,
> 
> JComboBox was still crashing under Norman's stress tests.  The crash
> always occurred in window_get_new_state where we were calling
> XGetWindowProperty to support the two window state hints that GTK
> doesn't support: _NET_WM_STATE_MAXIMIZED_VERT and
> _NET_WM_STATE_MAXIMIZED_HORZ.  Since the workaround was causing so many
> problems, I removed it and filed a proper GTK bug:
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=315647

Here's the patch that removes window_get_new_state.

Tom

2005-09-09  Thomas Fitzsimmons  <address@hidden>

        PR swing/23796
        * gnu/java/awt/peer/gtk/GtkDialogPeer.java
        (create): Respect dialog's decorated flag.

Index: gnu/java/awt/peer/gtk/GtkDialogPeer.java
===================================================================
RCS file: 
/cvsroot/classpath/classpath/gnu/java/awt/peer/gtk/GtkDialogPeer.java,v
retrieving revision 1.26
diff -u -r1.26 GtkDialogPeer.java
--- gnu/java/awt/peer/gtk/GtkDialogPeer.java    2 Jul 2005 20:32:12 -0000       
1.26
+++ gnu/java/awt/peer/gtk/GtkDialogPeer.java    9 Sep 2005 15:37:24 -0000
@@ -83,7 +83,8 @@
   void create ()
   {
     // Create a decorated dialog window.
-    create (GDK_WINDOW_TYPE_HINT_DIALOG, true);
+    create (GDK_WINDOW_TYPE_HINT_DIALOG,
+            !((Dialog) awtComponent).isUndecorated ());
 
     Dialog dialog = (Dialog) awtComponent;