classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] FYI: GapContent fix


From: Roman Kennke
Subject: [cp-patches] FYI: GapContent fix
Date: Thu, 08 Sep 2005 12:03:10 +0200

Hi,

This fixes bug#22966.

Note that I added an assert statement, AFAICS the first assert statement
in Classpath. This is really a case where I consider this useful. If
anybody has a problem with this, then scream and yell and I'll change
this into an if statement with exception.

I also added a testcase to Mauve for this bug, so that a regression gets
noticed. The GapContent is a low level class used in all text
components. If it's behaviour changes, then this breaks the text
components in subtle ways.

2005-09-08  Roman Kennke  <address@hidden>

        * javax/swing/text/GapContent.java
        Fixes Bug #22966.
        (GapContentPosition.getOffset): Added assertion to check for
        consistent state of the Position. Fixed condition in
        if-statement.
        (serialVersionUID): Updated serialVersionUID to match JDK1.5.
        (shiftGap): If gapStart == newGapStart, then return immediatly.

/Roman

Attachment: GapContent.diff
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]