Re: [cp-patches] FYI: Some quick fixes for accessibility in Swing

[Andrew John Hughes]

On Tue, 2005-09-06 at 21:53 +0100, Paul Jenner wrote:
> Hi Roman.
> 
> On Tue, 2005-09-06 at 22:41 +0200, Roman Kennke wrote:
> > I re-enabled some accessibility things in javax.swing that have been
> > disabled due to a compiler bug in gcj < 4
> >
> > 2005-09-06  Roman Kennke  <address@hidden>
> > 
> >         * javax/swing/Box.java
> >         (AccessibleBox): Extend Container.AccessibleAWTContainer.
> >         (Filler.AccessibleBoxFiller): Extend
> >     Component.AccessibleAWTComponent.
> >         (Filler.getAccessibleContext): Uncomment disabled code.
> >         (getAccessibleContext): Uncomment disabled code.
> >         * javax/swing/JRootPane.java:
> >         JRootPane implements Accessible.
> >         (AccessibleJRootPane): Extend AccessibleJComponent.
> 
> There was a very similar patch for javax.swing.Box with some javadoc and
> code (?) change from Andrew in this post:
> 
> http://lists.gnu.org/archive/html/classpath-
> patches/2005-01/msg00238.html
> 
> I'll be honest and admit that I have not looked at the patch in detail
> but is there anything else of the original patch that could now also be
> merged?
> 
> Paul
> 

The original patch by me is pretty much a subset of Roman's patch in
terms of code (it just uncomments the one for Box), but there is some
documentation in there as well, which may be worth adding to the final
committed version.  It was done for exactly the same reason (to
re-enable code that won't work with gcj < 4), but obviously ahead of its
time... now 0.18 is done, I believe the idea is to drop support for
earlier versions of gcj, making such a patch is now acceptable.

Cheers,
-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint)
attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn."
-- Richard Stallman

Escape the Java Trap with GNU Classpath!
http://www.gnu.org/philosophy/java-trap.html
public class gcj extends Freedom implements Java { ... }

signature.asc
Description: This is a digitally signed message part