classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] native/fdlibm/mprec.c: -Wall warning fixes


From: Christian Thalinger
Subject: [cp-patches] native/fdlibm/mprec.c: -Wall warning fixes
Date: Fri, 20 May 2005 17:51:02 +0200

Hi!

We compile CACAO and thus classpath with -Wall to get rid of all
warnings. mprec.c had some problems here.

TWISTI


2005-05-20  Christian Thalinger  <address@hidden>

        * native/fdlibm/mprec.c: Fixes to compile with -Wall without 
        warnings (mostly parentheses in arithmetic).



Index: native/fdlibm/mprec.c
===================================================================
RCS
file: /ahome/cacao/cacaocvs/cacao/src/classpath/native/fdlibm/mprec.c,v
retrieving revision 1.3
diff -u -3 -p -r1.3 mprec.c
--- native/fdlibm/mprec.c       14 Jul 2004 18:29:02 -0000      1.3
+++ native/fdlibm/mprec.c       20 May 2005 15:32:37 -0000
@@ -385,7 +385,7 @@ _DEFUN (mult, (ptr, a, b), struct _Jv_re
 #else
   for (; xb < xbe; xc0++)
     {
-      if (y = *xb++)
+      if ((y = *xb++))
        {
          x = xa;
          xc = xc0;
@@ -488,11 +488,11 @@ _DEFUN (lshift, (ptr, b, k), struct _Jv_
       z = 0;
       do
        {
-         *x1++ = *x << k & 0xffff | z;
+         *x1++ = ((*x << k) & 0xffff) | z;
          z = *x++ >> k1;
        }
       while (x < xe);
-      if (*x1 = z)
+      if ((*x1 = z))
        ++n1;
     }
 #endif
@@ -718,18 +718,18 @@ _DEFUN (b2d, (a, e),
   if (k < Ebits + 16)
     {
       z = xa > xa0 ? *--xa : 0;
-      d0 = Exp_1 | y << k - Ebits | z >> Ebits + 16 - k;
+      d0 = Exp_1 | y << (k - Ebits) | z >> (Ebits + 16 - k);
       w = xa > xa0 ? *--xa : 0;
       y = xa > xa0 ? *--xa : 0;
-      d1 = z << k + 16 - Ebits | w << k - Ebits | y >> 16 + Ebits - k;
+      d1 = z << (k + 16 - Ebits) | w << (k - Ebits) | y >> (16 + Ebits
- k);
       goto ret_d;
     }
   z = xa > xa0 ? *--xa : 0;
   w = xa > xa0 ? *--xa : 0;
   k -= Ebits + 16;
-  d0 = Exp_1 | y << k + 16 | z << k | w >> 16 - k;
+  d0 = Exp_1 | y << (k + 16) | z << k | w >> (16 - k);
   y = xa > xa0 ? *--xa : 0;
-  d1 = w << k + 16 | y << k;
+  d1 = w << (k + 16) | y << k;
 #endif
 ret_d:
 #ifdef VAX
@@ -812,22 +812,22 @@ _DEFUN (d2b,
 #endif
     }
 #else
-  if (y = d1)
+  if ((y = d1))
     {
-      if (k = lo0bits (&y))
+      if ((k = lo0bits (&y)))
        if (k >= 16)
          {
-           x[0] = y | z << 32 - k & 0xffff;
-           x[1] = z >> k - 16 & 0xffff;
+           x[0] = y | ((z << (32 - k)) & 0xffff);
+           x[1] = (z >> (k - 16)) & 0xffff;
            x[2] = z >> k;
            i = 2;
          }
        else
          {
            x[0] = y & 0xffff;
-           x[1] = y >> 16 | z << 16 - k & 0xffff;
+           x[1] = y >> 16 | ((z << (16 - k)) & 0xffff);
            x[2] = z >> k & 0xffff;
-           x[3] = z >> k + 16;
+           x[3] = z >> (k + 16);
            i = 3;
          }
       else






reply via email to

[Prev in Thread] Current Thread [Next in Thread]