Re: [cp-patches] java.beans.PropertyEditorSupport.setValue

[Mark Wielaard]

Hi Robert,

On Sun, 2004-10-31 at 15:30, Robert Schuster wrote:
> +2004-10-31  Robert Schuster <address@hidden>
> +
> +     * java/beans/PropertyEditorSupport.java
> +     (setValue): fixed bug #10799
> +

Could you write that as follows?

2004-10-31  Robert Schuster <address@hidden>

        Fixes bug #10799.
        * java/beans/PropertyEditorSupport.java
        (setValue): Fire property change event

(See also http://www.gnu.org/software/classpath/docs/hacking.html#SEC9)

> +             // report the change without mentioning the old and the new 
> values
> +             // (according to specification in 
> java.beans.PropertyChangeEvent)
> +             pSupport.firePropertyChange(null, null, null);

We should probably mention this fact (that when name is null then both
old and new value should also be null) explicitly in our
PropertyChangeSupport and/or PropertyChangeEvent documentation.

But even without that, please commit.
And thanks for writing Mauve tests for it.

Cheers,

Mark

signature.asc
Description: This is a digitally signed message part