Re: [cp-patches] [Patch] autogen.sh

[Michael Koch]

On Friday 15 October 2004 23:39, Mark Wielaard wrote:
> Hi,
>
> On Fri, 2004-10-15 at 09:02, Michael Koch wrote:
> > I just commited the attached patch to improve our autogen.sh
> > script. It now aborts when the versions of autoconf, automake or
> > libtool are not sufficient. This should make it easier to track
> > down problems for users.
>
> Nice. What was the reason again to not just recommend autoreconf?
>
> +if test -z "$AUTOGEN_SUBDIR_MODE"; then
> +        if test -z "$*"; then
> +                echo "I am going to run ./configure with no
> arguments - if you wish " +                echo "to pass any to it,
> please specify them on the $0 command line." +        fi
>
> This confused me greatly since I had obviously not set
> AUTOGEN_SUBDIR_MODE. And later on the test is reversed:
>
> +if test "x$AUTOGEN_SUBDIR_MODE" = "xyes"; then
> +        $srcdir/configure --enable-maintainer-mode
> $AUTOGEN_CONFIGURE_ARGS "$@" || exit $? +
> +        echo
> +        echo "Now type 'make' to compile $PROJECT."
> +fi
>
> This second test seems correct. The first one is wrong.

Damn, I changed the second to not run ./configure by default ... I 
don't like this. I will change the comment on the top. Thanks for 
pointing to this.


Michael