Re: [cp-patches] [Patch] java.rmi - cleanup

[Michael Koch]

On Friday 15 October 2004 14:35, Mark Wielaard wrote:
> On Fri, 2004-10-15 at 12:44, Michael Koch wrote:
> > --- java/rmi/activation/ActivationSystem.java   13 Oct 2003
> > 06:29:48 -0000      1.3 +++
> > java/rmi/activation/ActivationSystem.java   15 Oct 2004 10:42:39
> > -0000 @@ -1,5 +1,5 @@
> > -/*
> > -  Copyright (c) 1996, 1997, 1998, 1999 Free Software Foundation,
> > Inc. +/* ActivationSystem.java --
> > +i  Copyright (c) 1996, 1997, 1998, 1999, 2004  Free Software
> > Foundation, Inc.
>
>    ^
>    \-- that i doesn't belong here.
>
> > --- java/rmi/server/RemoteRef.java      12 Oct 2003 15:32:01
> > -0000      1.4 +++ java/rmi/server/RemoteRef.java      15 Oct
> > 2004 10:42:39 -0000 [...]
> >  public interface RemoteRef extends Externalizable
> >  {
> > -  long serialVersionUID = 0;
> > +  long serialVersionUID = 3632638527362204081L;
>
> Please add a note here why we need this particular uid.
> Since there were a couple of methods added in later versions.
> It might be nice to mark these methods so people know they are not
> actually always available when using/exchanging object with an
> older version. (Likewise for java/rmi/server/ServerRef.java)
>
> You really should note these kind of changes in the ChangeLog
> entry. Changing the serialVersionUID makes these new versions
> incompatible with our old implementation (but the old version was
> clearly wrong, so nothing we can really do about that).

Damn, this wasnt meant for commit. I will revert it.


Michael