Re: [cp-patches] [Patch] java.nio cleanup

[Michael Koch]

On Friday 15 October 2004 12:00, Mark Wielaard wrote:
> Hi,
>
> On Fri, 2004-10-15 at 09:27, Michael Koch wrote:
> > I just commited the attached patch to cleanup java.nio a bit.
> > Import statements and small coding style nits.
> > [...]
> > --- java/nio/MappedByteBuffer.java      8 Apr 2004 21:25:59
> > -0000       1.11
> > +++ java/nio/MappedByteBuffer.java      15 Oct 2004 07:26:46
> > -0000 [...]
> > -  public void finalize () { unmapImpl(); }
> > +  public void finalize()
> > +    throws Throwable
> > +  {
> > +    unmapImpl();
> > +  }
> >  }
>
> Why is this finalize method public and not protected?
> And why does it need to throw Throwable?
> Any reason to have this finalize method at all in this class.
> It seems that finalize(), unmapImpl() and forceImpl() should only
> be defined in MappedByteBufferImpl.

Don't know. Ask SUN. It's in the API this way.


Michael