Re: [cp-patches] Re: Add JSpinner and friends added

[Michael Koch]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Samstag, 2. Oktober 2004 10:20 schrieb Ka-Hing Cheung:
> On Sat, 2004-10-02 at 09:46 +0200, Michael Koch wrote:
> > I don't looked into the patch yet but it seems the diff is
> > uptodate with latest CVS as it e.g. deletes the serialVersionUID
> > field. This field is needed for our implementation.
>
> Oops, sorry about that. Patch reattached.

Some formatting nitpicks:

- -    if (listener != null)
+    if(listener != null)

We use a "space" between keywords and parenthesis (not between 
method/class names and parenthesis).

Its preferable to put all variables at top of the class (thats the 
most common place for them in GNU classpath).

e.g.: private Waker waker;

You reorder some stuff like methods. This makes the diff much harder 
to read. If this is really needed this should be done in another 
patch.

Sorry, I don*t wanna bother you with this. I just make it easier for 
us to review you patches. Your work is really appreciated. THANKS.


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBXmoZWSOgCCdjSDsRAkFSAJ0d+NfuMcn31O8WmmQmEWygvipahACeLCzx
PP/KklpN39LTHwSRwhmsiUE=
=2Zz3
-----END PGP SIGNATURE-----