Re: [cp-patches] Documentation update for java.util.GregorianCalendar

[Andrew John Hughes]

On Fri, 2004-09-10 at 09:17, Mark Wielaard wrote:
> Hi,
> 
> On Fri, 2004-09-10 at 04:48, Andrew John Hughes wrote:
> > Here's the next part in what seems to have extended into
> > a full audit of at least the documentation in java.util.
> > This one is GregorianCalendar, and it is also adds the odd
> > fix to code compilation with Jikes and serialization.
> 
> I assume the jikes compilation was an error about a shadowed field.
> The serialization readObject() looks right.
> And I assume the getActualMaximum() is also correct.
> If you could add a test case for that for mauve then this is fine.
> 
> Thanks again for the documentation update.
> 
> Cheers,
> 
> Mark

Yes, the two Jikes errors were a shadowed field in getLinearTime() and a
fall-through to the default case in getActualMaximum() (the full info.
on these is in the ChangeLog).  These corrections and readObject() are
the only code changes.  Where possible, I'll try and squish the Jikes
warnings as I go through (the Currency patch also does one).  The rest
are documentation additions/modifications/whatever you want to call it.

As to Mauve, unless you feel this is a must-have before the commit, then
I'd prefer to postpone checking out the Mauve testcases for this class
until my pending commit access comes through.  I have a few patches
already to go in (including one for the new class I created,
javax.swing.SpinnerListModel) and I'd prefer to leave this until I can
work with the tests fully, along with the main code (really, I should
backtrack over the other classes, to check things out and see if there
are any more tests that can be added).  As we don't have readObject()
now and Sun does, then we are already most likely not serialization
compatible.

Anyway, let me know as to whether to commit or wait on Mauve,
Cheers,
-- 
Andrew :-)
 
Please avoid sending me Word or PowerPoint attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html
 
Value your freedom, or you will lose it, teaches history.
`Don't bother us with politics' respond those who don't want to learn.

signature.asc
Description: This is a digitally signed message part