chicken-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-users] I'm looking for suggestions regarding vectors vs. record


From: Matt Welland
Subject: [Chicken-users] I'm looking for suggestions regarding vectors vs. records vs. coops (again).
Date: Sun, 24 Jul 2016 11:06:32 -0700

For years now I've been using inlined vectors instead of records or coops for data structures due to performance concerns. Recently I was training someone on how to maintain my code and I felt quite lame explaining the vector records. So I started switching to defstruct records. However I've started to hit some performance issues and one factor seems to be the records (more work to do to confirm this). 

Below is a simplistic benchmark comparing using inlined vectors, inlined vectors with a type check, defstruct and coops. Where performance matters using vectors or type checked vectors seems to help. The benchmark seems enough to hint to me to switch back to vectors - especially in cases where I'm slinging around 10's of thousands of records.

My question: can anyone offer insight into a better way to balance performance with elegance/flexibility of records?

BTW: Yes, I'm sure there are plenty of other aspects to my code that need optimization but the thrust of my question is on records.

================the results================
address@hidden:/mfs/matt/data/megatest$ csc -O2 records-vs-vectors-vs-coops.scm && ./records-vs-vectors-vs-coops

Using vectors
1.484s CPU time, 33162750/0 mutations (total/tracked), 3/6608 GCs (major/minor)

Using vectors (safe mode)
2.456s CPU time, 0.012s GC time (major), 49744125/0 mutations (total/tracked), 18/22291 GCs (major/minor)

Using defstruct
6.636s CPU time, 0.016s GC time (major), 33162750/0 mutations (total/tracked), 54/60476 GCs (major/minor)

Using coops
24.1s CPU time, 1.16s GC time (major), 33162760/2 mutations (total/tracked), 1550/272935 GCs (major/minor)


================the code================
(use foof-loop defstruct coops)

(defstruct obj     type pts fill-color text line-color call-back angle font attrib extents proc)

;; Generated using make-vector-record vgs obj type pts fill-color text line-color call-back angle font attrib extents proc
(define (make-vg:obj)(make-vector 10))
(define-inline (vg:obj-get-type         vec)    (vector-ref  vec 0))
(define-inline (vg:obj-get-pts          vec)    (vector-ref  vec 1))
(define-inline (vg:obj-get-fill-color   vec)    (vector-ref  vec 2))
(define-inline (vg:obj-get-text         vec)    (vector-ref  vec 3))
(define-inline (vg:obj-get-line-color   vec)    (vector-ref  vec 4))
(define-inline (vg:obj-get-call-back    vec)    (vector-ref  vec 5))
(define-inline (vg:obj-get-angle        vec)    (vector-ref  vec 6))
(define-inline (vg:obj-get-font         vec)    (vector-ref  vec 7))
(define-inline (vg:obj-get-attrib       vec)    (vector-ref  vec 8))
(define-inline (vg:obj-get-extents      vec)    (vector-ref  vec 9))
(define-inline (vg:obj-get-proc         vec)    (vector-ref  vec 10))
(define-inline (vg:obj-set-type!        vec val)(vector-set! vec 0 val))
(define-inline (vg:obj-set-pts!         vec val)(vector-set! vec 1 val))
(define-inline (vg:obj-set-fill-color!  vec val)(vector-set! vec 2 val))
(define-inline (vg:obj-set-text!        vec val)(vector-set! vec 3 val))
(define-inline (vg:obj-set-line-color!  vec val)(vector-set! vec 4 val))
(define-inline (vg:obj-set-call-back!   vec val)(vector-set! vec 5 val))
(define-inline (vg:obj-set-angle!       vec val)(vector-set! vec 6 val))
(define-inline (vg:obj-set-font!        vec val)(vector-set! vec 7 val))
(define-inline (vg:obj-set-attrib!      vec val)(vector-set! vec 8 val))
(define-inline (vg:obj-set-extents!     vec val)(vector-set! vec 9 val))
(define-inline (vg:obj-set-proc!        vec val)(vector-set! vec 10 val))

(use simple-exceptions)
(define vgs:obj-exn (make-exception "wrong record type, expected vgs:obj." 'assert))
(define (make-vgs:obj)(let ((v (make-vector 12)))(vector-set! v 0 'vgs:obj) v))
(define-inline (vgs:obj-type             vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 1)(raise (vgs:obj-exn 'vgs:obj-type 'xpr))))
(define-inline (vgs:obj-pts              vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 2)(raise (vgs:obj-exn 'vgs:obj-pts 'xpr))))
(define-inline (vgs:obj-fill-color       vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 3)(raise (vgs:obj-exn 'vgs:obj-fill-color 'xpr))))
(define-inline (vgs:obj-text             vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 4)(raise (vgs:obj-exn 'vgs:obj-text 'xpr))))
(define-inline (vgs:obj-line-color       vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 5)(raise (vgs:obj-exn 'vgs:obj-line-color 'xpr))))
(define-inline (vgs:obj-call-back        vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 6)(raise (vgs:obj-exn 'vgs:obj-call-back 'xpr))))
(define-inline (vgs:obj-angle            vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 7)(raise (vgs:obj-exn 'vgs:obj-angle 'xpr))))
(define-inline (vgs:obj-font             vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 8)(raise (vgs:obj-exn 'vgs:obj-font 'xpr))))
(define-inline (vgs:obj-attrib           vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 9)(raise (vgs:obj-exn 'vgs:obj-attrib 'xpr))))
(define-inline (vgs:obj-extents          vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 10)(raise (vgs:obj-exn 'vgs:obj-extents 'xpr))))
(define-inline (vgs:obj-proc             vec)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-ref  vec 11)(raise (vgs:obj-exn 'vgs:obj-proc 'xpr))))
(define-inline (vgs:obj-type-set!        vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 1 val)(raise (vgs:obj-exn 'type))))
(define-inline (vgs:obj-pts-set!         vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 2 val)(raise (vgs:obj-exn 'pts))))
(define-inline (vgs:obj-fill-color-set!  vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 3 val)(raise (vgs:obj-exn 'fill-color))))
(define-inline (vgs:obj-text-set!        vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 4 val)(raise (vgs:obj-exn 'text))))
(define-inline (vgs:obj-line-color-set!  vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 5 val)(raise (vgs:obj-exn 'line-color))))
(define-inline (vgs:obj-call-back-set!   vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 6 val)(raise (vgs:obj-exn 'call-back))))
(define-inline (vgs:obj-angle-set!       vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 7 val)(raise (vgs:obj-exn 'angle))))
(define-inline (vgs:obj-font-set!        vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 8 val)(raise (vgs:obj-exn 'font))))
(define-inline (vgs:obj-attrib-set!      vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 9 val)(raise (vgs:obj-exn 'attrib))))
(define-inline (vgs:obj-extents-set!     vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 10 val)(raise (vgs:obj-exn 'extents))))
(define-inline (vgs:obj-proc-set!        vec val)(if (eq? (vector-ref vec 0) 'vgs:obj)(vector-set! vec 11 val)(raise (vgs:obj-exn 'proc))))

(define-class <vgc> ()
  ((type)
   (pts)
   (fill-color)
   (line-color)
   (call-back)
   (angle)
   (font)
   (attrib)
   (extents)
   (proc)))


;; first use raw vectors
(print "Using vectors")
(time
 (loop ((for r (up-from 0 (to 255))))
       (loop ((for g (up-from 0 (to 255))))
         (loop ((for b (up-from 0 (to 255))))
           (let ((obj (make-vg:obj)))
             (vg:obj-set-type! obj 'abc)
             (vg:obj-set-fill-color! obj "green")
             (vg:obj-set-angle! obj 135)
             (let ((a (vg:obj-get-type obj))
               (b (vg:obj-get-fill-color obj))
               (c (vg:obj-get-angle obj)))
               obj))))))

;; first use raw vectors with safe mode
(print "Using vectors (safe mode)")
(time
 (loop ((for r (up-from 0 (to 255))))
       (loop ((for g (up-from 0 (to 255))))
         (loop ((for b (up-from 0 (to 255))))
           (let ((obj (make-vgs:obj)))
             ;; (badobj (make-vector 20)))
             (vgs:obj-type-set! obj 'abc)
             (vgs:obj-fill-color-set! obj "green")
             (vgs:obj-angle-set! obj 135)
             (let ((a (vgs:obj-type obj))
               (b (vgs:obj-fill-color obj))
               (c (vgs:obj-angle obj)))
               obj))))))

;; first use defstruct
(print "Using defstruct")
(time
 (loop ((for r (up-from 0 (to 255))))
       (loop ((for g (up-from 0 (to 255))))
         (loop ((for b (up-from 0 (to 255))))
           (let ((obj (make-obj)))
             (obj-type-set! obj 'abc)
             (obj-fill-color-set! obj "green")
             (obj-angle-set! obj 135)
             (let ((a (obj-type obj))
               (b (obj-fill-color obj))
               (c (obj-angle obj)))
               obj))))))
          

;; first use defstruct
(print "Using coops")
(time
 (loop ((for r (up-from 0 (to 255))))
       (loop ((for g (up-from 0 (to 255))))
         (loop ((for b (up-from 0 (to 255))))
           (let ((obj (make <vgc>)))
             (set! (slot-value obj 'type) 'abc)
             (set! (slot-value obj 'fill-color) "green")
             (set! (slot-value obj 'angle) 135)
             (let ((a (slot-value obj 'type))
               (b (slot-value obj 'fill-color))
               (c (slot-value obj 'angle)))
               obj))))))


reply via email to

[Prev in Thread] Current Thread [Next in Thread]