[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-users] [PATCH] (low priority) Make locative-ref inlineable

From: Peter Bex
Subject: Re: [Chicken-users] [PATCH] (low priority) Make locative-ref inlineable (ticket #1260)
Date: Thu, 19 May 2016 21:51:02 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, May 18, 2016 at 09:25:08PM +0200, Kooda wrote:
> Hi,
> I was browsing and found this low hanging bug so I gave it a 
> shot.
> I hope I didn’t mess up too much.

Hi Kooda!

Many thanks for picking up the pace again.  This is the ideal first
commit for master after we branched off I think.

I made small changes to your version:
- Added a NEWS entry to point out that C_locative_ref is deprecated
- Added /* DEPRECATED */ to the C_locative_ref entry in
   create_initial_ptable(), so we don't forget to remove it there
   once we remove the obsolete function.

Attached is a signed-off copy, plus a port to CHICKEN 5, which is a bit
hairier than you'd think because needs to handle bignums.  Those can be
returned when accessing locatives into {s,u}32vectors and there are now
also the new {s,u}64vectors which obviously may return bignums too.

Plus, the locatives procedures have moved to their own module
(chicken.locative), which means it moved around in the file *and* has a
prefix in types.db now.  Merge conflicts galore ;)

Small nitpick: As I also mentioned on IRC, patches for CHICKEN core
should go to chicken-hackers, not chicken-users, so I'm CCing this mail
to both lists.


Attachment: 0001-Make-locative-ref-inlineable-ticket-1260.master.patch
Description: Text Data

Attachment: 0001-Make-locative-ref-inlineable-ticket-1260.chicken-5.patch
Description: Text Data

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]