chicken-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-users] proposed change to http-client


From: Elf
Subject: Re: [Chicken-users] proposed change to http-client
Date: Wed, 13 Feb 2008 08:05:45 -0800 (PST)

<snip>

Hm, probably.
I was thinking of reusing http:request object,
which would be used both for http:GET and http:POST, for example.

It would be nice if the handling of Connection: close
is consistent with http:POST and http:GET.


oh, i added a utility procedure to take care of those sorts of cases. if youre reusing a connect, you can now do
 (http:request-attribute-add! reqobj attribname val) , which will either
add the attrib if its not there or change the previous val in place (no header reordering) if it already exists.


how is it inconsistent?  http posts should close connect afterwards, its not
a continuable operation, from my understandings.

Here, http:POST overwrite Connection header in req.
I guess correct behavior is of http:GET,
because with HTTP/1.1 the absence of the Connection header
means keep-alive.
a
Oh, or are you saying that http:POST should ALWAYS close connection?

i was saying that i thought it should always lose connection, but graham pointed out that i was incorrect. theres a separate issue of 1.0 being default
though.




BTW, is the old place
 https://galinha.ucpel.tche.br/svn/chicken-eggs/http/trunk
obsoleted?
(I wan't following this branching issue very well...)
i


no, i just did it in the v3 branch and didnt backport it.  since im using
v3 and there was pressing need for it to be working, i just did the minimal
work necessary.  i will backport it if desired (assuming here that the
changes will not be reverted due to popular demand. :) )

I wish chicken-eggs/http -> chicken-eggs/release/2/http,
but as I said, I wasn't following the issue.


chicken-eggs/release/2 doesnt exist... that would be the current 'main'
(ie, not release/3 branch) implementation.  or maybe it does exist now and i
just havent gotten it cause im totally out of space on this box, in which case,
im sorry. either way, id be happy to backport it after its been worked out what changes are desired, whether the changes should have been made, making
sure nothing breaks, etc.

-elf

--daishi





reply via email to

[Prev in Thread] Current Thread [Next in Thread]