chicken-janitors
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-janitors] Re: #396: Handle empty path components in uri-generic


From: Chicken Trac
Subject: [Chicken-janitors] Re: #396: Handle empty path components in uri-generic/uri-common
Date: Wed, 22 Sep 2010 13:38:38 -0000

#396: Handle empty path components in uri-generic/uri-common
-------------------------+--------------------------------------------------
  Reporter:  sjamaan     |       Owner:  sjamaan                                
 
      Type:  defect      |      Status:  new                                    
 
  Priority:  minor       |   Milestone:  4.7.0                                  
 
 Component:  extensions  |     Version:  4.6.x                                  
 
Resolution:              |    Keywords:  uri, pedantic strictness, rfc, 
standards
-------------------------+--------------------------------------------------

Comment(by sjamaan):

 Replying to [comment:7 iraikov]:
 > I meant the discarding-of-empty-path-segments behavior. Some actual test
 cases that illustrate why this is a problem.

 Phew! Glad you agree :)

 > Now that I think about it, SMB file sharing URIs are also very insistent
 about keeping a large number of consecutive slashes, so I would not be
 surprised if the current uri-generic breaks those. And as I wrote this, I
 just realized that the uri-generic test cases do not include any SMB URIs,
 so we need to fix this, regardless of the outcome of this ticket.

 Could you come up with some particularly nasty examples? I have never
 really used SMB.
 I'm not sure having a lot of real-world examples matters that much, it's
 mostly the edge cases that are interesting for the tests. If we nail those
 down, the run-of-the-mill URIs will take care of themselves. But having a
 few example SMB uris would be good (just put them in the path-cases list.
 Be sure to update the comment too since these wouldn't be Python cases
 :P).

 > It does sound like keeping the empty path segments would be a sane
 behavior. Backward compatibility should not be a big issue, if any user of
 the library wanted to write their own normalization procedure that removes
 the empty segments, they can call update-uri and filter the path
 accordingly.

 Agreed!

-- 
Ticket URL: <http://bugs.call-cc.org/ticket/396#comment:8>
Chicken Scheme <http://www.call-with-current-continuation.org/>
Chicken Scheme is a compiler for the Scheme programming language.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]