[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix missing argument for barf on out-of-range error (u8vecto
From: |
Peter Bex |
Subject: |
Re: [PATCH] Fix missing argument for barf on out-of-range error (u8vector-set!) |
Date: |
Tue, 5 Nov 2024 14:20:26 +0100 |
On Tue, Nov 05, 2024 at 02:09:55PM +0100, Peter Bex wrote:
> I think we'd do best to completely replace all barf(C_OUT_OF_RANGE, ...)
> calls in a bigger patch and make it use 5 instead of 4 arguments.
hm, I just realised that changing c = 2 to c = 3 in
"case C_OUT_OF_RANGE_ERROR" on runtime.c:1716 would mean it's a
backwards compatibility breaking change, so we can't just do that.
Maybe in the CHICKEN 6 branch we can get away with it? It's still quite
subtle though, and will cause nasty runtime breakage of code that calls
barf() directly.
Of course, refactoring this could work for the CHICKEN 6 branch, if we
also just completely rename the barf() interface to ensure no existing
callers will be silently affected.
Cheers,
Peter