chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix for #1132


From: Peter Bex
Subject: Re: [PATCH] fix for #1132
Date: Wed, 8 Nov 2023 13:50:06 +0100

On Wed, Nov 08, 2023 at 12:34:23PM +0100, felix.winkelmann@bevuta.com wrote:
> See commit message.

Shouldn't we modify the test instead of dropping it?

Something like this:

(module m3 ()
  (import (rename scheme (define s:define)))
  (import (only (chicken base) assert))
  (define-syntax define
    (syntax-rules ()
      ((_) (display 'oink))
      ((_ var value) (s:define var (+ value 1)))))
  (define)
  (let ()
    (define a 1)
    (assert (= a 2)))
  (define)
  (newline))

Not sure it's useful to have that final define and newline there.
Perhaps we can drop that, or change it do something more meaningful.
We could simply change it to (define b 5) followed by (assert (= b 6)).

Cheers,
Peter

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]