[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] handle misquoting of target in build-scripts

From: Peter Bex
Subject: Re: [PATCH] handle misquoting of target in build-scripts
Date: Tue, 1 Nov 2022 10:41:45 +0100

On Mon, Oct 31, 2022 at 05:46:55PM +0100, wrote:
> Thanks, pushed. I had to hand-apply the patch as git-am didn't like it. I also
> fixed a scrutinizer warning.

I suppose the warning was about target-librarian-options not being a
list?  Unfortunately, splicing in these options wouldn't work properly -
they're taken from a baked in foreign value which may contain spaces.

We'll have to figure out a way to keep certain arguments "as-is".
Attached is a pretty straightforward proposal to make this work.

PS: I noticed two more mistakes that have nothing to do with this - just
the platform was still being passed in to "filelist" and was *not* being
passed in to print-build-command.  I've fixed these already and pushed
them as trivial patches.


Attachment: 0001-Add-a-way-to-pass-in-already-quoted-arguments-to-qs.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]