[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] better error message with unknown component-dependency

From: kooda
Subject: Re: [PATCH] better error message with unknown component-dependency
Date: Wed, 03 Mar 2021 12:11:51 +0100
User-agent: OtterMail wrote:
> Reported by wasamasa.

Resurecting this bug report.

As reference, here is an example egg file that shows the error (from wasamasa):

((synopsis "Broken")
 (components (program test (component-dependencies test-files))
             (data test-files (files "test.txt"))))

Unknown component dependenciy errors are already handled in filter-deps, the 
problem here is trying to generate build commands for data files.

The original proposed patch displays an error message even though the egg file 
is valid, it’s just a no-op to have a data component as a dependency, because 
the data is always there.
I think having this kind of error message (“unknown dependency: test-files” for 
the above example) would be very confusing.

Here is a different patch for this issue: it just adds the three missing cases 
for static data components, mapping them to an empty build command list.
For good measure there’s also a fallback case that prints an error message 
indicating that there is a bug in chicken-install if we someday add a new 
component type and forget to add its build commands.

Attachment: txtRaXaN9FlC4.txt
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]