[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix #1665 by blocking direct calls to externally inlineable proc

From: Peter Bex
Subject: [PATCH] Fix #1665 by blocking direct calls to externally inlineable procedures
Date: Mon, 10 Feb 2020 16:04:05 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

Hi all,

Attached is a relatively straightforward patch for #1665.  The unroll
limit was causing the procedure calls to stay, and the compiler would
replace those calls with a direct call, thinking the fid would be valid
locally (but it isn't, because it was loaded from an external file).

Without the unroll limit patch, the entire procedure call would be
replaced with the inlined version.  I'm not sure, there may be a bug
in the logic there as well, because I don't think this actually should
hit the unroll limit.

In the example, the (bar 'xxx) and (bar 'yyy) calls get replaced, but
the (bar 'zzz) call does not.  I don't think the unroll limit is supposed
to apply to the different calls before replacement.


Attachment: 0001-Don-t-directly-call-external-inlineable-procedures-f.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]