chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] make -:hs0 truly disable heap shrinking


From: Peter Bex
Subject: Re: [PATCH] make -:hs0 truly disable heap shrinking
Date: Sat, 28 Dec 2019 14:35:45 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

On Sun, Dec 22, 2019 at 11:09:12AM +0100, address@hidden wrote:
> Hi!
> 
> "-:hs0" is currently ineffective, since validity checks between parsing
> the option and initializing the heap overwrite the setting.
> 
> This patch initializes the heap-parameter variables statically,
> removes the validity checks and does an explicit check for
> C_heap_shrinkage being 0.

Thanks, pushed.

> I think the validity checks for the other settings are not really worth
> it - if the user wants to tweak the heap settings, let her, even if it
> may make no sense.

At first I thought it is better to keep the checks.  On the other hand,
there are so many combinations that make no sense we can't ever check
them all, anyway.

Cheers,
Peter

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]