Re: [PATCH] Improve heap shrinkage calculation

[Peter Bex]

On Sun, Dec 01, 2019 at 11:22:37PM +0100, address@hidden wrote:
> It seems to work fine, but "-:hs0" doesn't seem to work. I tried
> 
>     csi -:d -:hs0
>     > (define x (make-vector 10000000))
>     > (##sys#gc)
>     > (##sys#gc)
>     > ...
> 
> The heap is still shrunk on each GC. "-:hs100" works, but isn't really
> useful, as it resizes the heap to the previous value.

I think megane mentioned this on IRC the other day as well.  It looks
like this has been broken for a while already.

In C_rereclaim2:

  if(size < MINIMAL_HEAP_SIZE) size = MINIMAL_HEAP_SIZE;

If the percentage is zero, "size" will be zero and the line above will
reset the heap size to the minimal heap size.

Why is -:hs100 not useful?  You don't want it to resize at all?

Cheers,
Peter

signature.asc
Description: PGP signature