[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Chicken-hackers] [PATCH] Fix #1470 and unignore clean/pure declarations
From: |
Peter Bex |
Subject: |
[Chicken-hackers] [PATCH] Fix #1470 and unignore clean/pure declarations |
Date: |
Sun, 25 Aug 2019 12:28:25 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi all,
I was looking through our ticket tracker and encountered #1470.
It looks like the specific test case mentioned there does not exist
anymore, but I decided it's a good idea regardless.
While doing that, I noticed that when running with -specialize, I got
slightly different output for predicates. For example, the reported
type of string? is (* --> boolean) instead of (* -> boolean) as in the
"expected" file. I checked the code, and when loading types database
files, we skip marking variables as #:pure or #:clean unless we're
specializing. I asked Felix and he agreed that this seems incorrect.
So the attached patch consists of two changes; the first ensures we
always honour these annotations when loading types databases, the second
enables -specialize for the scrutiny tests as suggested by #1470.
Cheers,
Peter
0001-Also-load-clean-and-pure-annotations-from-types.db-w.patch
Description: Text Data
0002-Run-scrutiny-tests-with-specialize.patch
Description: Text Data
signature.asc
Description: PGP signature
- [Chicken-hackers] [PATCH] Fix #1470 and unignore clean/pure declarations,
Peter Bex <=