[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Fix define-foreign-type fuckup

From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Fix define-foreign-type fuckup
Date: Tue, 7 May 2019 21:12:45 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Hi all,

My previous patch to improve hygiene for the FFI broke
define-foreign-type because ##core#set does not register its
defined variable like "define" does (see today's Salmonella).
So, later references to the identifier would cause errors inside
a module, because the module didn't know the identifier existed.

After pondering this a bit, I realised this could be a hidden
nasty bug, see

Anyway, here's a simple fix, we can work on a proper fix for #1615
later, as this is not a new problem and so far hasn't caused issues.
The attached patch simply behaves the same as the old unhygienic
version that called define did.


Attachment: 0001-Fix-how-define-foreign-type-defines-its-conversion-p.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]