Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages

[Evan Hanson]

On 2019-01-10 18:12, megane wrote:
> Evan Hanson <address@hidden> writes:
> > Here's a signed-off version of the first patch in this set. I've also
> > updated the Windows test script and added the new files to the
> > distribution manifest.
> >
> > Please feel free to review and apply this one without waiting for the
> > others in megane's message. Doing it gradually is the only way we'll get
> > through all these.
>
> You'll have to redo your changes to the first patch, sorry about that.

No worries, here's the same again with a sign-off.

> Do you agree with approach I took about gensym'd variables in the second
> patch? If not, I think I'll have to come up with something else.

That's a nice idea, I think it's probably fine. But if we're going to do
that, why not wipe line numbers in all the expected files rather than
just the new one?

> diff --git a/tests/redact-gensyms.scm b/tests/redact-gensyms.scm
> new file mode 100644
> index 0000000..c6abb7b
> --- /dev/null
> +++ b/tests/redact-gensyms.scm
> @@ -0,0 +1,25 @@
> + (define prefixes (if (null? (command-line-arguments))
> +                         '("tmp" "g")
> +                         (string-split (car (command-line-arguments)) ",")))
> +
> + (let ((rege (irregex `(: ($ (or ,@prefixes)) (+ numeric)))))

This regex could be `(: bow ($ (or ,@prefixes)) (+ numeric)) so you avoid
accidentally replacing numbers in something like a variable called "dog1".

Evan

0001-Add-new-test-for-scrutinizer-message-formatting.patch
Description: Text Data