[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some
From: |
megane |
Subject: |
Re: [Chicken-hackers] [PATCH] Use vertical space more liberally in some scrutinizer messages |
Date: |
Mon, 19 Nov 2018 20:21:01 +0200 |
User-agent: |
mu4e 1.0; emacs 25.1.1 |
address@hidden writes:
>>
>> Hi,
>>
>> Here's a reworked patch set. It's not exactly small, but I tried to make
>> it pretty easy to follow. Except maybe for the last patch, which
>> digs for some extra info from the nodes.
>>
>> There's small bit of back-and-forth in the patches:
>> - errors? is taken out of let and put back
>> - report-notice lingers unused before getting deleted
>>
>> There were some whitespace warnings when I applied this, but everything
>> seemed to work fine.
>
> I'm vehemently against patches that merely change whitespace or
> layout (patch 1/9) and make it impossible to track changes properly.
You can give the -w switch to git blame to see through whitespace
changes. Or (setq vc-git-annotate-switches '("-w")) in emacs if you're
using vc-annotate, which I'd suggest anyone to try.
>
>
> felix