[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Move "sleep" into chicken.time and expose
|
From: |
Peter Bex |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Move "sleep" into chicken.time and expose "process-sleep" from chicken.time.posix |
|
Date: |
Sun, 28 Jan 2018 13:30:32 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Jan 22, 2018 at 02:27:39PM +1300, Evan Hanson wrote:
> Hey Peter,
>
> I'd prefer that we put 'sleep' in chicken.base and 'process-sleep' in
> chicken.process. Currently, the two 'time' modules only deal with
> measuring time and handling "time objects", and I think it makes sense
> to keep them that way. Instead, since 'sleep' pauses the runtime and
> 'process-sleep' pauses the process, base and process do make a lot of
> sense to me.
>
> Here's an updated patch, in case this change is OK with you.
Sounds okay to me. One question, though: shouldn't chicken.base#sleep-hook
be defined as a fully-qualified symbol? It isn't exported.
Or does the (not (inline )) declaration guarantee that this will work as
intended?
Cheers,
Peter
signature.asc
Description: PGP signature