chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH][5] FFI improvements, take two


From: lemonboy
Subject: [Chicken-hackers] [PATCH][5] FFI improvements, take two
Date: Wed, 14 Jun 2017 21:39:13 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Hello hackers,
the first two patches are meant to be applied after you review them, they are
pretty much the same I've previously sent but with some minor corrections so
those should be fine now.

Both the patches target the define-foreign-type form: the first patch fixes a 
regression where the tl? flag was not propagated when walking the inner `begin`
form which defines some auxiliary functions, the other one makes sure form is
always used in toplevel contexts like the other define- forms.

The same cannot be done for `define-foreign-variable` since that's used in
`foreign-type-size` and `foreign-value` to locally define foreign variables on
the go. This asymmetry is nothing too serious but makes me wonder if we should
remove the toplevelness (heh) checks in `walk` and generate
`##core#ensure-toplevel-definition` nodes when needed instead.

Time to get those upstreamed, they've been sitting in my git repo for too long
:)

Cheers,
Lemonboy

Attachment: 0001-Propagate-the-tl-flag-to-the-inner-definitions.patch
Description: Text Data

Attachment: 0002-Restrict-define-foreign-type-forms-to-the-toplevel.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]